Some bug fixes and some advice needed

["Carlos Y. Villalpando" <unbelver@brain.jpl.nasa.gov>]

Hey all.

Tom, sorry if you get this twice, but I'm not sure if you are on
vanilla-l and I wanted to make sure you got this.

I've got spare time and I've been going through the PROJECTS file.
I just committed fixes to these two bug reports:

INL robot problems reported by fugitive@ugcs.caltech.edu

        - observers cannot become captain, they are told to choose a
          team first.  (Code in inlcomm.c check_player())

INL robot problems reported by sheldon@visi.com

        - one team set gametime and armies, but the other team did not,
          and yet the game still started.

But the real reson I'm writing is to ask advice on this bug report:

INL robot problems reported by d4sand,

        - if game that is not ROM/FED ends, and players return to start
          another game, they can't be captain because "you must pick
          a team first."

This is because inl_reset switches it back to home-FED/away-ROM at the
end of the game, but not the tournmasks.   There's two ways to fix this:

  1) A brain-dead-simple fix.  Just don't reset the teams flags.
     Home/Away ports will join as the previous game's teams for the
     pre-game. No impact there.

And

  2) A simple fix.  At game end, change the tournmask and obliterate
     everybody to make them re-join FED/ROM. 

I've tried both, and both work, but since I don't run or really
participate the INL, I defer this decision to those who have a bigger
interest in it. 

Comments?

Oh, and I'm planning to see if this weekend I can get the INL robot to
recognize a geno and end the game without daemon kicking everybody off.

--Carlos V.