Vanilla List Maling List Archive
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [VANILLA-LIST:2150] cow stuff in the vanilla configure



On Wed, 17 Mar 1999 you wrote:
>Personally, I think stuff like
>
>if test "$code" = server; then
>  do some stuff
>fi
>
>if test "$code" = cow; then
>  do some stuff
>fi
>
>in the same configure files is extremely hard to maintain.

I would agree, if it is a large portion of the code, but since it's only
a very small thing, I don't see a problem with that.

>Especially when you are making changes to the configure that work for the
>server but might break things for cow.

Belive me, I check every changes here very carefully before I merge them
in into COW.  

>Can we split the two things out?

In earlier time the server and client used a lot of common defs files, which
always guarantied, that both are in sync. As a result of splitting things
up, COW for ex. recently had a bug that it crashed on phasered plasmas
because someone added some new whydead enums without notifying
the client development.

So I vote for merging more things, maybe even generating common
libraries instead of splitting up everything completely.

In particular all the C/S protocol stuff should be definitely in a common file.

Kurt (007)

--
Kurt Siegl / Franzberg 4, A-4483 Hargelsberg, Austria
Email: 007@netrek.org       Tel (ISDN):   *(7225)7017
URL:   http://www.ooenet.at/user/siegl/kurt/